fix: repair failing tests and type errors across api and shared packages - #106
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#106stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- implement paginate() utility in shared package (edge cases: empty, out-of-range, partial last page) - fix auth middleware HTTP method case-sensitivity so POST /users is public - import badRequest and align username field in users route - rename User.userName -> username in shared types for cross-package consistency - wire already-installed bun-types into tsconfig for process/bun:test resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and TypeScript errors in the repo. Final state: 22 pass / 0 fail,
tsc --noEmitclean.Changes
packages/shared/src/utils/pagination.ts— implemented thepaginate()stub. Returns the correct page slice withtotal,totalPages(Math.ceil),page,pageSize. Handles empty arrays, out-of-range pages (returns emptydata), partial last pages, and guardssize=0.packages/api/src/middleware/auth.ts— fixed the HTTP-method case-sensitivity bug soPOST /usersis treated as public. DELETE/PUT/PATCH without a token still return 401.packages/api/src/routes/users.ts— imported the missingbadRequesthelper and aligned field usage tousername.packages/shared/src/types.ts— renamedUser.userName→usernamefor cross-package consistency (tests useusername).tsconfig.json— addedbun-typesto resolveprocess/bun:test. Already a devDependency; no new dependencies added.Constraints honoured
bun-types).Verification
bun test→ 22 pass / 0 failnpx tsc --noEmit→ exit 0Assumptions
username(matching tests); the outlieruserNamewas renamed.